[PATCH] D32218: X86AsmParser.cpp asserts: OperandStack.size() > 1 && "Too few operands."

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 03:49:19 PDT 2017


RKSimon added a comment.

@mcrosier Any comments?



================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1335
 
+    AsmToken::TokenKind TK = getLexer().getKind();
     // The period in the dot operator (e.g., [ebx].foo.bar) is parsed as an
----------------
Did this actually need moving?


================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1341
+//      break;
 
     // If we're parsing an immediate expression, we don't expect a '['.
----------------
Don't comment out code - delete it.


https://reviews.llvm.org/D32218





More information about the llvm-commits mailing list