[PATCH] D31261: [IR] De-virtualize ~Value to save a vptr

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 15:00:20 PDT 2017


rnk added inline comments.


================
Comment at: llvm/include/llvm/IR/DerivedUser.h:42
+/// lib/IR.
+class ValueCallbacks {
+public:
----------------
pcc wrote:
> Can "ValueCallbacks" just be a function pointer?
It could be, but I had the idea that MemorySSA might prefer to add virtual methods here instead of doing switch dispatch like I ended up doing. Whatever dannyb/gbiv prefer, I'll do that.


https://reviews.llvm.org/D31261





More information about the llvm-commits mailing list