[PATCH] D33055: [LoopOptimizer][Fix]PR32859, PR24738

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 11:09:32 PDT 2017


davide added a comment.

This patch seems at least to plug a sane value rather than `undef` for the phi arg. 
I don't think this should go in without a vectorizer expert signing it off (i.e. @mkuper or @mssimpso).



================
Comment at: test/Transforms/LoopVectorize/pr32859.ll:26
+
+attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+
----------------
I think you can probably get rid of some attributes.


================
Comment at: test/Transforms/LoopVectorize/pr32859.ll:28-30
+!llvm.ident = !{!0}
+
+!0 = !{!"clang version 5.0.0 (http://llvm.org/git/clang.git 08c94e4bd75c5a2e4de5ea108d98739f5179dbeb) (http://llvm.org/git/llvm.git 7d66f52694bdfabf0081a1d40b99fca0c189a988)"}
----------------
Do you really need this?


https://reviews.llvm.org/D33055





More information about the llvm-commits mailing list