[PATCH] D33088: [LiveVariables] Switch Kill/Defs sets to be `DenseSet`

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 10:13:40 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D33088#752373, @MatzeB wrote:

> - Easier fix: The critical edge splitting appears to be a part of PHIElimination that happens before anything else. If we would pull that out into a separate pass and perform it before computing LiveVariables, then we wouldn't need to go through the trouble of updating LiveVariables.


Reading the code a bit more it seems that the critical edge splitting logic is already depending on liveness information so it's not that easy to fix.


https://reviews.llvm.org/D33088





More information about the llvm-commits mailing list