[PATCH] D33037: [IfConversion] Keep the CFG updated incrementally in IfConvertTriangle

[Kyle Butt via Phabricator via llvm-commits]

iteratee added a comment.

In https://reviews.llvm.org/D33037#750855, @uabelho wrote:

> I have on purpose not attacked IfConvertSimple, IfConvertForkedDiamond
>  and IfConvertDiamond to keep the size of the patch down, and I haven't seen any
>  test case where they actually go wrong, but I think they suffer from similar
>  problems since they also use RemoveExtraEdges/analyzeBranch to fix the CFG at
>  the end.


IfConvertForkedDiamond only applies to analyzable branches, so it should be safe.
If you change the others, it would be good to change it as well for consistency.

I'll leave time for others to comment, but overall it looks fine to me.


https://reviews.llvm.org/D33037