[PATCH] D32963: [AARCH64] Fix a comment to match the code. NFC.

Kristof Beyls via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 01:57:02 PDT 2017


kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.

LGTM, even if you don't implement the nitpicky suggestions I made.



================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:35
 AArch64MCAsmInfoDarwin::AArch64MCAsmInfoDarwin() {
-  // We prefer NEON instructions to be printed in the short form.
-  AssemblerDialect = AsmWriterVariant == Default ? 1 : AsmWriterVariant;
+  // We prefer NEON instructions to be printed in the short, apple-specific form.
+  AssemblerDialect = AsmWriterVariant == Default ? Apple : AsmWriterVariant;
----------------
you could add " when targeting Darwin" to the comment.


================
Comment at: lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp:71
 
-  // We prefer NEON instructions to be printed in the short form.
-  AssemblerDialect = AsmWriterVariant == Default ? 0 : AsmWriterVariant;
+  // We prefer NEON instructions to be printed in the generic form.
+  AssemblerDialect = AsmWriterVariant == Default ? Generic : AsmWriterVariant;
----------------
You could add " when targeting ELF" to the comment.


https://reviews.llvm.org/D32963





More information about the llvm-commits mailing list