[PATCH] D21723: [RFC] Enhance synchscope representation

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 15:30:41 PDT 2017


pcc added inline comments.


================
Comment at: lib/IR/LLVMContextImpl.cpp:218
 
+SyncScope::ID LLVMContextImpl::getSyncScopeID(StringRef SSN) const {
+  auto SSI = SSC.find(SSN);
----------------
kzhuravl wrote:
> pcc wrote:
> > Unused function
> I was planning to start using it in the follow up patch, which implements AMDGPU's memory model. Would that be ok to leave this function in this patch? Or should it be moved to the follow up patch?
Please move it to the follow-up so that we can see how it is used in context.


https://reviews.llvm.org/D21723





More information about the llvm-commits mailing list