[PATCH] D33024: [Support] Move LLD parallel algorithms to LLVM.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Maybe I'm stuck with an old diff or something?



================
Comment at: lld/COFF/Writer.cpp:748
       memset(SecBuf, 0xCC, Sec->getRawSize());
-    for_each(parallel::par, Sec->getChunks().begin(), Sec->getChunks().end(),
-             [&](Chunk *C) { C->writeTo(SecBuf); });
+    for_each(llvm::parallel::par, Sec->getChunks().begin(),
+             Sec->getChunks().end(), [&](Chunk *C) { C->writeTo(SecBuf); });
----------------
I find the fact that `for_each` is now getting looked up via ADL on the `llvm::parallel::par` type ... disturbing.


================
Comment at: llvm/include/llvm/Support/TaskGroup.h:51-53
 /// \brief Allows launching a number of tasks and waiting for them to finish
 ///   either explicitly via sync() or implicitly on destruction.
 class TaskGroup {
----------------
I thought all of this was being moved to be implementation details of the algorithms?

Also, all the code appears to still be LLD style?


https://reviews.llvm.org/D33024