[PATCH] D32252: [GVN] Add phi-translate for scalarpre as a temporary solution

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 18:47:31 PDT 2017


The compile time increase look small and acceptable given what it does and
performance we saw.

On the other hand, I assume you will also be on the hook to solve the
compile time problem longer term (i.e., helping newgvn deployment) :)

David


On Tue, May 9, 2017 at 3:59 PM, Wei Mi via Phabricator <
reviews at reviews.llvm.org> wrote:

> wmi updated this revision to Diff 98361.
> wmi added a comment.
>
> I change the DenseMap numberingExpression (mapping from value numbering to
> GVN::Expression) to std::vector. Although there is still some minor
> increase but better than before.
>
> 400.perlbench   0.81%
> 401.bzip2       -0.11%
> 403.gcc -0.42%
> 429.mcf 1.58%
> 433.milc        -0.33%
> 445.gobmk       0.85%
> 456.hmmer       0.07%
> 458.sjeng       -0.42%
> 462.libquantum  -0.75%
> 464.h264ref     -1.24%
> 470.lbm -0.65%
> 482.sphinx3     0.44%
> 998.specrand    0.00%
> 999.specrand    -1.74%
> 444.namd        0.28%
> 447.dealII      1.56%
> 450.soplex      0.96%
> 453.povray      -0.02%
> 471.omnetpp     0.02%
> 473.astar       0.18%
> 483.xalancbmk   0.85%
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32252
>
> Files:
>   include/llvm/Transforms/Scalar/GVN.h
>   lib/Transforms/Scalar/GVN.cpp
>   test/Transforms/GVN/PRE/phi-translate-2.ll
>   test/Transforms/GVN/PRE/pre-gep-load.ll
>   test/Transforms/GVN/PRE/pre-load.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170509/fb7379f6/attachment.html>


More information about the llvm-commits mailing list