[PATCH] D32887: [ELF] Emit __ehdr_start when there is a segment containing program headers

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 14:00:28 PDT 2017


Rui Ueyama via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> ruiu added a comment.
>
> These possible compatibility issues could be real concerns, but I think we should go with a simple way which is to define ehdr_start unconditionally. When we need to strike a balance among simplicity, efficiency and compatibility, we sometimes chose simplicity or efficiency over the 100% precise compatibility, and it seems to be working surprisingly well. It feels __ehdr_start is in the same category. We can add more code later if it really needs more complexity.

I am OK with starting with that. Please include that difference in a
testcase with a comment that the behavior is different from bfd to
simplify the implementation, but can be changed if there is a strong
need.

Cheers,
Rafael


More information about the llvm-commits mailing list