[PATCH] D31659: [LLD][ELF] Be more precise about Thumb state bit in ARM thunks

[Rafael Avila de Espindola via llvm-commits]

Peter Smith <peter.smith at linaro.org> writes:

> The second branch of reviews starts with D32799 this adds Thunks to
> InputSectionDescriptions::Sections and synchronizes with
> OutputSections::Sections at the end in order to be compatible with
> LinkerScript::synchronize(). I've not posted the remainder of the
> range extension Thunk patches on this approach, they will look very
> much like D31656 - D31666 but with small implementation details
> changed.
>
> What I think I really need to know right now is which approach to take
> D31656 - D31666 or D32799, once I know that I can update or abandon
> the reviews using the alternative approach. It would be great if you
> could take a look at D32799 and let me know your opinion?

I think the correct solution is to create synthetic sections earlier, so
that LinkerScript::synchronize can be deleted. Any code changing
OutputSections or the input sections in a particular OutputSection would
then be changing the linker script commands *instead*.

Cheers,
Rafael