[PATCH] D33014: Fix the Endianness bug by adding the little endian UTF marker.

[Zachary Turner via llvm-commits]

Not sure if my entire email got sent.  But I was saying there are multiple
APIs like for UTF16 and UTF32, various directions of conversion (8->16 and
16->8), etc.  So if it's going to be done for one function it makes sense
to do it everywhere.  then, there's the issue of sharing code between the
various overloads that will inevitably arise if we add a second overload of
each function.

I don't think it makes sense to block this fix on a largely cosmetic API fix

On Tue, May 9, 2017 at 12:34 PM Zachary Turner <zturner at google.com> wrote:

> Yes, bot is red. Even still, the unicode api fix is rather involved (I
> actually tried) and it doesn't seem worth blocking this on that since it's
> largely unrelated and there are a lot of boring details to handle like
> which subset of apis to do it for, how to res
>
> On Tue, May 9, 2017 at 12:32 PM Rui Ueyama via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> ruiu added a comment.
>>
>> Do you mean the bot is still red? If I broke something I'd first try to
>> roll it back if the error is not just a simple mistake but needs another
>> round of code review.
>>
>>
>> https://reviews.llvm.org/D33014
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170509/5961f25f/attachment.html>