[PATCH] D32990: [NewGVN] Take in account incoming edges computing congruent PhiExpression(s)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 11:19:42 PDT 2017


efriedma added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Scalar/NewGVN.cpp:742
+            [&](const Use *U1, const Use *U2) {
+              return PN->getIncomingBlock(*U1) < PN->getIncomingBlock(*U2);
+            });
----------------
Is there any possibility that sorting by pointer values here will give non-deterministic output?  If there isn't, please add a comment explaining why.


Repository:
  rL LLVM

https://reviews.llvm.org/D32990





More information about the llvm-commits mailing list