[PATCH] D32802: Add checks so that -pre-RA-sched=list-ilp does not crash on SystemZ (Bug 32723).

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 09:59:43 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D32802#749855, @jonpa wrote:

> In https://reviews.llvm.org/D32802#749851, @MatzeB wrote:
>
> > Just out of interested: What's the interested in these selection dag schedulers, I though they are deprecated and only SourceListDAGScheduler and possibly SchedulerDAGFast are of interest with the MachineScheduler around.
> >
> > Is this because of the same reasons (or same benchmark?) that motivated https://reviews.llvm.org/D32563 ?
>
>
> This was just a bug I discovered with llvm-stress. As long as this option is around, it shouldn't mean that the compiler crashes when it is used, right?  (Perhaps an exit with some kind of message explaining that this scheduler is unsupported might due instead...?)


As far as I am concerned I would happily remove this option. But as usual I don't know why it wasn't removed when the MachineScheduler was introduced and who/what targets may be depending on it...


https://reviews.llvm.org/D32802





More information about the llvm-commits mailing list