[PATCH] D32987: DWARF: When parsing type unit headers take the length field into account.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 09:05:49 PDT 2017


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Might be worth keeping the DWARF64 change separately until it's testable/valid, so test coverage can properly be assessed at that point.



================
Comment at: test/DebugInfo/Inputs/typeunit-header.s:11-12
+# Real type unit dies have quite different attributes of course, but we
+# just need to demonstrate an issue with validating length, so we just give it
+# a single visibility attribute.
+        .section .debug_abbrev,"", at progbits
----------------
Do you need to give it any attributes at all?


https://reviews.llvm.org/D32987





More information about the llvm-commits mailing list