[PATCH] D32961: [Polly][PPCGCodeGen] OpenCL now gets kernel argument size from PPCG CodeGen

Philipp Schaad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 9 01:07:23 PDT 2017


PhilippSchaad added a comment.

I personally find it better like this, because the `i` is per-loop, so it is self contained in every iteration, the `Index` however is across loops. To me, this way it is more clear, that the `Index` is not a loop-specific iteration variable. 
Let's see what the others think though. Either way, I would suggest moving that to a different patch indeed, should we decide on changing that.

(Will address your commented points in just a second, agree with both of them.)


https://reviews.llvm.org/D32961





More information about the llvm-commits mailing list