[PATCH] D20723: Don't generate unnecessary signed ConstantRange during multiply

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 8 17:36:42 PDT 2017


craig.topper added a comment.

Sorry to dredge this back up. But isn't that only ensuring the lower bound is positive? It doesn't guarantee anything about the upper bound. So I think we are returning full set for [-2, -2] * [0, 1] through the unsigned code and not even checking the signed range.


Repository:
  rL LLVM

https://reviews.llvm.org/D20723





More information about the llvm-commits mailing list