[PATCH] D32614: [GVNHoist] Fix: PR32821, add check for anticipability in case of infinite loops

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added a comment.

In https://reviews.llvm.org/D32614#749269, @chandlerc wrote:

> You are continuing to argue that you do not need to add tests because they will pass. That seems to be missing the point. Tests are what verify and validate these kinds of arguments and assumptions, both now and in the future.


I'll add more tests which will reflect different aspects of cyclic control flow. I was trying to explain what program points handle specific cases pointed by you. It will be good if you can suggest any resources which can help create a variety of CFGs.

> I already said in my response that I acknowledge that these tests will likely pass. It still seems extremely important to have specific, targeted test coverage of the different kinds of control flows. I will stop repeating myself after this message.




https://reviews.llvm.org/D32614