[PATCH] D32971: [scudo] CRC32 optimizations

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added inline comments.


================
Comment at: lib/scudo/scudo_allocator.cpp:39
-
-INLINE u32 computeCRC32(u32 Crc, uptr Data, u8 HashType) {
-  // If SSE4.2 is defined here, it was enabled everywhere, as opposed to only
----------------
It looked nice to have a separate function that wraps all of this logic. Why do you inline it?
I would just move the load of HashAlgorithm into this function so that it does not happen when not needed.


https://reviews.llvm.org/D32971