[PATCH] D32609: Update llvm-readobj -coff-resources to display tree structure.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:1571
+                          makeArrayRef(ResourceTypeNames));
+        IDStr = IDStr.slice(0, IDStr.find_first_of(")", 0) + 1);
+      } else {
----------------
chapuni wrote:
> It writes back part of SmallString via StringRef.
> Could you rewrite not to modify (SmallString)IDStr?
Is it necessarily incorrect to modify IDStr in this case?  The StringRef points to something we own within this scope.


https://reviews.llvm.org/D32609