[PATCH] D32609: Update llvm-readobj -coff-resources to display tree structure.

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni added a comment.

This is failing on some builders, includes valgrind, possibly sanitizers.

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/9118
http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/13960



================
Comment at: llvm/lib/Object/COFFObjectFile.cpp:1610
+  std::string DirString;
+  if (!llvm::convertUTF16ToUTF8String(RawDirString, DirString))
+    return object_error::parse_failed;
----------------
I can suggest that converter may be moved to caller, then this method may return StringRef.


================
Comment at: llvm/lib/Object/COFFObjectFile.cpp:1612
+    return object_error::parse_failed;
+  return DirString;
+}
----------------
Don't return local std::string as StringRef.


================
Comment at: llvm/tools/llvm-readobj/COFFDumper.cpp:1571
+                          makeArrayRef(ResourceTypeNames));
+        IDStr = IDStr.slice(0, IDStr.find_first_of(")", 0) + 1);
+      } else {
----------------
It writes back part of SmallString via StringRef.
Could you rewrite not to modify (SmallString)IDStr?


https://reviews.llvm.org/D32609