[PATCH] D32563: Add LiveRangeShrink pass to shrink live range within BB.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 7 12:56:59 PDT 2017


sanjoy added a subscriber: skatkov.
sanjoy added a comment.

The reordering code here is reminding me of the reordering code in ImplicitNullChecks.  Is there an opportunity to share code here?

+CC @skatkov



================
Comment at: lib/CodeGen/LiveRangeShrink.cpp:55
+// M[A] > M[B] guarantees that A is dominated by B.
+// If \p New is not in \p M, return \p Old. Othwise if \p Old is null, return
+// \p New.
----------------
s/Othwise/Otherwise/


================
Comment at: lib/CodeGen/LiveRangeShrink.cpp:85
+  const auto E = Start->getParent()->instr_end();
+  for (MachineBasicBlock::instr_iterator I = Start; I != E; I++) {
+    M[&*I] = i++;
----------------
Range for?


https://reviews.llvm.org/D32563





More information about the llvm-commits mailing list