[PATCH] D21723: [RFC] Enhance synchscope representation

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:1755
+  if (!SSIDs.empty())
+    return error("Invalid multiple blocks");
+
----------------
"Invalid multiple sync scope names blocks"


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:4600
+    return SyncScope::ID(Val);
+  return SSIDs[Val];
+}
----------------
Should this assert(Val < SSIDs.size()) to ensure that the bitcode is not using a value that is not in the SYNC_SCOPE_NAMES_BLOCK_ID block?


https://reviews.llvm.org/D21723