[PATCH] D32946: [InstCombine] Merge duplicate functionality between InstCombine and ValueTracking

[Takuto Ikuta via Phabricator via llvm-commits]

takuto.ikuta added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:3523
+    MaxRHS.clearSignBit();
+    APInt Result = std::move(MaxLHS) + std::move(MaxRHS);
+    return Result.isSignBitClear();
----------------
Can I ask you to remove `std::move`s?
These have no meaning here.


================
Comment at: lib/Analysis/ValueTracking.cpp:3537
+    MinRHS.clearSignBit();
+    APInt Result = std::move(MinLHS) + std::move(MinRHS);
+    return Result.isSignBitSet();
----------------
ditto.


https://reviews.llvm.org/D32946