[PATCH] D31247: [Polly][DeLICM] Known knowledge.

[Tobias Grosser via Phabricator via llvm-commits]

grosser accepted this revision.
grosser added a comment.
This revision is now accepted and ready to land.

Hi Michael,

this looks good to me. I just have a couple of minor typos. I also tried this of some of the polybench kernels, but it seems not yet enough to make them really faster. The one thing we need for a simple gemm kernel is -polly-delicm-overapproximate-writes=true, the second is an option to remove redundant writes. I assume these will be handled in later changes, so no need to block this patch.

Best,
Tobias



================
Comment at: lib/Transform/DeLICM.cpp:119
+//
+//     * SCEV[...] - An synthesizable llvm::SCEV Expression.
+//         In contrast to a Value[] is has at least one dimension per
----------------
A synthesizable


================
Comment at: lib/Transform/DeLICM.cpp:1202
+  ///
+  /// Although LLVM IR used single static assignment, llvm::Values can have
+  /// different contents in loops, when they get redefined in the last
----------------
uses.


================
Comment at: lib/Transform/DeLICM.cpp:1235
+    // If the definition/write is conditional, the value at the location could
+    // be either the written value, or the old value. Since we cannot know which
+    // one, consider the value to be unknown.
----------------
no need for comma here.


================
Comment at: test/DeLICM/reduction_looprotate.ll:13
+;
+; There is nothing to in this case. All accesses are in body.
+;
----------------
to DO in


https://reviews.llvm.org/D31247