[PATCH] D32887: [ELF] Emit __ehdr_start when there is a segment containing program headers

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 13:40:02 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/Writer.cpp:1190
 
+  if (ElfSym::EhdrStart) {
+    auto PhdrI =
----------------
What is this doing?


================
Comment at: ELF/Writer.cpp:1195
+    if (PhdrI == Phdrs.end()) {
+      forEachRelSec([&](InputSectionBase &S) {
+        if (S.AreRelocsRela)
----------------
Re-scanning all relocations is probably too slow.


Repository:
  rL LLVM

https://reviews.llvm.org/D32887





More information about the llvm-commits mailing list