[PATCH] D32890: Split up lld Parallel.h a bit

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 11:19:36 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. This patch splits the files without changing any behavior and also fixes variable names. I want you to commit this before you make further changes, as I want to separate mechanical changes from non-mechanical ones.



================
Comment at: lld/include/lld/Core/TaskGroup.h:28-31
+  uint32_t _count;
+  mutable std::mutex _condMut;
+  mutable std::condition_variable _cond;
+
----------------
Please fix these names.


================
Comment at: lld/include/lld/Core/TaskGroup.h:56
+class TaskGroup {
+  Latch _latch;
+
----------------
And this.


https://reviews.llvm.org/D32890





More information about the llvm-commits mailing list