[PATCH] D32762: [Atomics] Let emitTrailingFence take the loaded value. NFC.

[Tim Shen via Phabricator via llvm-commits]

timshen updated this revision to Diff 97986.
timshen added a comment.
Herald added a subscriber: javed.absar.

Patch rewritten.

Now both emitLeadingFence and emitTrailingFence take the instruction itself, instead of taking IsLoad/IsStore pairs. Instead, Instruction::mayReadFromMemory and Instrucion::mayWriteToMemory are used for determining those two booleans.

The instruction argument is also useful for later https://reviews.llvm.org/D32763, in emitTrailingFence. For emitLeadingFence, it seems to have cleaner interface with the proposed change.


https://reviews.llvm.org/D32762

Files:
  llvm/include/llvm/Target/TargetLowering.h
  llvm/lib/CodeGen/AtomicExpandPass.cpp
  llvm/lib/Target/ARM/ARMISelLowering.cpp
  llvm/lib/Target/ARM/ARMISelLowering.h
  llvm/lib/Target/PowerPC/PPCISelLowering.cpp
  llvm/lib/Target/PowerPC/PPCISelLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32762.97986.patch
Type: text/x-patch
Size: 11932 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170505/46d31728/attachment.bin>