[PATCH] D32821: Add DWARF verifiers to verify address ranges are correct and scoped correctly.

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked 2 inline comments as done.
clayborg added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:44
+      if (Ranges[I].first > Ranges[I].second) {
+        OS << "error: invalid range in DIE\n";
+        HasErrors = true;
----------------
aprantl wrote:
> It doesn't look like this is tested? (as far as I can tell by searching for the error message).
I added a test.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:73
+        ++NumDebugInfoErrors;
+        OS << "error: DIEs have overlapping address ranges:\n";
+        Prev->Die.dump(OS, 0);
----------------
aprantl wrote:
> test?
There are two: TestDwarfVerifyOverlappingFunctionRanges and TestDwarfVerifyOverlappingLexicalBlockRanges


https://reviews.llvm.org/D32821