[PATCH] D32908: [ScopBuilder] Move Scop::init to ScopBuilder. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 07:06:14 PDT 2017


Meinersbur created this revision.
Meinersbur added a project: Polly.

`Scop::init` is used only during SCoP construction. Therefore ScopBuilder seems the more appropriate place for it. We integrate it onto its only caller `ScopBuilder::buildScop` where some other construction steps already took place.

There was a bail-out check

  if (!scop->hasFeasibleRuntimeContext())
    return;

at the end of the init function. Since `hasFeasibleRuntimeContext` has no side-effects, this was a no-op. Now it guards the call of `verifyUses`.

Follow-up patches could move the individual construction step methods to ScopBuilder as well.


https://reviews.llvm.org/D32908

Files:
  lib/Analysis/ScopBuilder.cpp
  lib/Analysis/ScopInfo.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32908.97950.patch
Type: text/x-patch
Size: 5276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170505/f77a9c7f/attachment.bin>


More information about the llvm-commits mailing list