[PATCH] D32776: Enable branch coalescing on PowerPC

Kit Barton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 20:04:46 PDT 2017


kbarton accepted this revision.
kbarton added a comment.
This revision is now accepted and ready to land.

Aside from two minor comments, this LGTM.
Please make sure to update the release notes when this gets committed.



================
Comment at: include/llvm/Target/TargetSubtargetInfo.h:139
 
+  /// \brief True if the subtarget supports branch coalescing
+  virtual bool enableBranchCoalescing() const;
----------------
We no longer need \brief since autobrief has been turned on for doxygen. 


================
Comment at: test/CodeGen/PowerPC/branch_coalesce.ll:2
+; RUN: llc -mcpu=pwr8 -mtriple=powerpc64le-unknown-linux-gnu -verify-machineinstrs < %s | FileCheck %s
+; RUN: llc -mcpu=pwr8 -mtriple=powerpc64-unknown-linux-gnu -verify-machineinstrs < %s | FileCheck %s
+; RUN: llc -enable-branch-coalesce=false -mcpu=pwr8 -mtriple=powerpc64le-unknown-linux-gnu -verify-machineinstrs < %s | FileCheck --check-prefix=CHECK-NOCOALESCE %s
----------------
There is nothing specific to pwr8 in this patch so I think we're better to remove -mcpu=pwr8. 


https://reviews.llvm.org/D32776





More information about the llvm-commits mailing list