[PATCH] D32826: Move Parallel.h from LLD to LLVM

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 16:29:40 PDT 2017


zturner added a comment.

In https://reviews.llvm.org/D32826#746628, @chandlerc wrote:

> So, my concern about reviewing this isn't just about the implementation, it's also about the *API*. We need to make sure that the API design for parallel building blocks that we want to be available for the entire LLVM project are right. That's the particular split I was looking for...
>
> There is also the fact that all of the code is currently still in LLD's old coding convention and needs to be updated to LLVM's coding conventions before it moves IMO.


Fair enough, I'll work on fixing up the coding conventions and segregating the Windows/non-Windows codepaths so it's a little less ugly to look at.  In the meantime, feel free to either continue reviewing as time permits or wait for an update.


https://reviews.llvm.org/D32826





More information about the llvm-commits mailing list