[PATCH] D32826: Move Parallel.h from LLD to LLVM

[Michael Spencer via llvm-commits]

On Thu, May 4, 2017 at 11:41 AM, Rui Ueyama via Phabricator <
reviews at reviews.llvm.org> wrote:

> ruiu added a comment.
>
> If we are going to examine this file, I strongly recommend porting the
> same functionalities (i.e. parallel_for and parallel_for_each) on top of
> llvm/Support/ThreadPool.h. I don't think that is hard to do as TheadPool.h
> seems to provide the same functionality as this file. That would be easier
> than review this file again.
>
>
> https://reviews.llvm.org/D32826
>
>
>
>
My issue with just using Support/ThreadPool for everything is that
lld/Parallel.h uses ConcRT on Windows and is quite a bit faster than both
our implementations of thread pools. I don't want to punish Windows
performance. I'd also rather have our interface match whatever the standard
is doing in terms of parallel task execution.

- Michael Spencer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170504/6f8c546e/attachment.html>