[PATCH] D32865: [llvm-dwarfdump] - Print an error message if section decompression failed.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Seems generally fine, couple of suggestions inline.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFContext.h:313
 
+  Error maybeDecompress(const object::SectionRef &Sec, StringRef Name,
+                        StringRef &Data);
----------------
I would remove the "maybe" here.


================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:948
+
+  SmallString<32> Out;
+  if (auto Err = Decompressor->decompress(Out))
----------------
Is a section likely to be < 32 bytes?


https://reviews.llvm.org/D32865