[PATCH] D31908: [AntiDepBreaker] Don't rename callee saved register restore instruction

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 07:50:37 PDT 2017


kparzysz added a comment.

In https://reviews.llvm.org/D31908#746050, @hfinkel wrote:

> Could we check this in the verifier? One advantage this might have is that, for blocks ending in unreachable, we can easily realize that we don't need the restoration code.


Are we adding restoration code to such blocks now?  That could be checked in the verifier, but it's not incorrect.  Maybe a warning could be issued...

The verifier should be able to check if the callee-saved registers are properly marked as live/used in the relevant places (return instructions, etc.)


https://reviews.llvm.org/D31908





More information about the llvm-commits mailing list