[PATCH] D32682: Refactoring with range-based for, NFC

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 06:05:42 PDT 2017


kparzysz added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:523
   // Bottom up: release predecessors
-  for (SUnit::pred_iterator I = SU->Preds.begin(), E = SU->Preds.end();
-       I != E; ++I) {
-    ReleasePred(SU, &*I);
-    if (I->isAssignedRegDep()) {
+  for (auto &Pred : SU->Preds) {
+    ReleasePred(SU, &Pred);
----------------
Seems like the autos in this file have not been converted to types.  I somehow missed this the last time.


https://reviews.llvm.org/D32682





More information about the llvm-commits mailing list