[PATCH] D32857: [ARM] Mark LEApcrel as not having side effects

[John Brawn via Phabricator via llvm-commits]

john.brawn created this revision.
Herald added subscribers: rengolin, aemerson.

Doing this lets us hoist it out of loops, and I've also marked it as rematerializable the same as the thumb1 and thumb2 counterparts.

It looks like it being marked as such was just a mistake, as the commit that made that change only mentions LEApcrelJT and in thumb2 only the t2LEApcrelJT instruction was marked as having side-effects, so it looks like the intent was to only mark LEApcrelJT as having side-effects but LEApcrel was accidentally marked as such also.


Repository:
  rL LLVM

https://reviews.llvm.org/D32857

Files:
  lib/Target/ARM/ARMInstrInfo.td
  test/CodeGen/ARM/adr-hoist.ll


Index: test/CodeGen/ARM/adr-hoist.ll
===================================================================
--- /dev/null
+++ test/CodeGen/ARM/adr-hoist.ll
@@ -0,0 +1,31 @@
+; RUN: llc -mtriple=armv7a   %s -o - | FileCheck %s
+; RUN: llc -mtriple=thumbv7m %s -o - | FileCheck %s
+; RUN: llc -mtriple=thumbv6m %s -o - | FileCheck %s
+
+ at arr = internal unnamed_addr constant [4 x i32] [i32 305419896, i32 -1430532899, i32 -2023406815, i32 -573785174], align 4
+
+; Check that the adr of arr is hoisted out of the loop
+; CHECK: adr [[REG:r[0-9]+]], .LCP
+; CHECK: .LBB
+; CHECK-NOT adr
+; CHECK: ldr{{(.w)?}} {{r[0-9]+}}, {{\[}}[[REG]],
+
+define void @fn(i32 %n, i32* %p) {
+entry:
+  %cmp8 = icmp sgt i32 %n, 0
+  br i1 %cmp8, label %for.body, label %for.cond.cleanup
+
+for.body:
+  %i.09 = phi i32 [ %inc, %for.body ], [ 0, %entry ]
+  %arrayidx = getelementptr inbounds i32, i32* %p, i32 %i.09
+  %0 = load i32, i32* %arrayidx, align 4
+  %arrayidx1 = getelementptr inbounds [4 x i32], [4 x i32]* @arr, i32 0, i32 %0
+  %1 = load i32, i32* %arrayidx1, align 4
+  store i32 %1, i32* %arrayidx, align 4
+  %inc = add nuw nsw i32 %i.09, 1
+  %exitcond = icmp eq i32 %inc, %n
+  br i1 %exitcond, label %for.cond.cleanup, label %for.body
+
+for.cond.cleanup:
+  ret void
+}
Index: lib/Target/ARM/ARMInstrInfo.td
===================================================================
--- lib/Target/ARM/ARMInstrInfo.td
+++ lib/Target/ARM/ARMInstrInfo.td
@@ -2221,14 +2221,14 @@
   let Inst{11-0} = label{11-0};
 }
 
-let hasSideEffects = 1 in {
+let hasSideEffects = 0, isReMaterializable = 1 in
 def LEApcrel : ARMPseudoInst<(outs GPR:$Rd), (ins i32imm:$label, pred:$p),
                     4, IIC_iALUi, []>, Sched<[WriteALU, ReadALU]>;
 
+let hasSideEffects = 1 in
 def LEApcrelJT : ARMPseudoInst<(outs GPR:$Rd),
                       (ins i32imm:$label, pred:$p),
                       4, IIC_iALUi, []>, Sched<[WriteALU, ReadALU]>;
-}
 
 //===----------------------------------------------------------------------===//
 //  Control Flow Instructions.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32857.97807.patch
Type: text/x-patch
Size: 2050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170504/55ae53d2/attachment.bin>