[PATCH] D32684: [X86] Adding new LLVM TableGen backend that generates the X86 backend memory folding tables.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 03:37:20 PDT 2017


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/stack-folding-fp-avx1.ll:1654
 
-define double @stack_fold_sqrtsd(double %a0) {
-  ;CHECK-LABEL: stack_fold_sqrtsd
----------------
aymanmus wrote:
> RKSimon wrote:
> > Please don't delete tests, especially if they've regressed - show the new codegen and add a todo comment
> The test checks that specific instructions are memory folded.
> In the removed test cases, the instructions were removed from the memory folding tables so testing that these instructions are NOT folded in this test, is not the best idea.
OK - so just leave TODO comments for the 4 cases:
```
; TODO stack_fold_sqrtsd
; TODO stack_fold_sqrtsd_int
; TODO stack_fold_sqrtss
; TODO stack_fold_sqrtss_int
```





https://reviews.llvm.org/D32684





More information about the llvm-commits mailing list