[PATCH] D32826: Move Parallel.h from LLD to LLVM

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 03:09:36 PDT 2017


I could do it 1 function at a time, but that doesn't seem super useful.
Note that the entire windows code path just delegates to an OS API and can
be largely ignored. So i think it's actually not all that much code.

I was afraid someone might call for a more thorough review which is why i
added dvyukov@

That said, maybe it's worth looking into how thoroughly it was reviewed
before going into LLD?
On Thu, May 4, 2017 at 2:55 AM Chandler Carruth via Phabricator <
reviews at reviews.llvm.org> wrote:

> chandlerc added a comment.
>
> So, I understand that this is just moving code from LLD to LLVM, but this
> is pretty complex and subtle code. I think it needs really careful and
> thorough review. I'm going to try to plan some time for that, but I wonder
> -- are there any meaningful splits you can make to introduce this more
> incrementally to LLVM
>
>
> https://reviews.llvm.org/D32826
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170504/963c53fb/attachment.html>


More information about the llvm-commits mailing list