[PATCH] D32850: [ArgPromotion] Fix a truncated variable

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 02:48:48 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D32850#745797, @rengolin wrote:

> Wouldn't it be better to set the type manually to something like `uint32_t` or `uint64_t`? To make sure they're the same across all arches?


That'd work as well. Although in this case, `ArgIndex.second` is a `std::vector<uint64_t>`, so `auto` here always means `uint64_t`, regardless of platform.


https://reviews.llvm.org/D32850





More information about the llvm-commits mailing list