[PATCH] D32744: [globalisel] Improve legalizer DEBUG_ONLY output.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 01:42:48 PDT 2017


dsanders added a comment.

In https://reviews.llvm.org/D32744#745035, @aditya_nandakumar wrote:

> Just to clarify, this wouldn't work if the target decided to insert new instructions before PrevMII (or even at the beginning for e.g.). I'm guessing if the target does that, its not a big deal if we don't print it.


That's right. It's my understanding that targets are supposed to substitute instructions in place, similar to the legalizer in SelectionDAG. If a target does something else it will need to add it's own DEBUG()


https://reviews.llvm.org/D32744





More information about the llvm-commits mailing list