[PATCH] D32274: [XRay] Detect loops in functions being lowered

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 16:03:35 PDT 2017


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good with a small suggestion



================
Comment at: lib/CodeGen/XRayInstrumentation.cpp:40
+    AU.addRequired<MachineLoopInfo>();
+    AU.addPreserved<MachineLoopInfo>();
+    MachineFunctionPass::getAnalysisUsage(AU);
----------------
This pass at least preserves MachineDomTree, so let's add that too. It seems consistent with other MI passes.


https://reviews.llvm.org/D32274





More information about the llvm-commits mailing list