[PATCH] D32663: [SCEV] createAddRecFromPHI: Optimize for the most common case.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 15:49:02 PDT 2017


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm, but the test case change looks fishy.  This change is NFC right?



================
Comment at: include/llvm/Analysis/ScalarEvolution.h:820
+  /// A helper function for createAddRecFromPHI to handle simple cases.
+  const SCEV *createSimpleAffineAddRec(PHINode *PN, Value *BEValueV,
+                                            Value *StartValueV);
----------------
Indent?


================
Comment at: test/CodeGen/X86/2014-08-29-CompactUnwind.ll:27
 
-define void @__asan_report_error() #0 {
+define void @__asan_report_error(i64 %step) #0 {
   %str.i = alloca i64, align 8
----------------
Why did you change this?


https://reviews.llvm.org/D32663





More information about the llvm-commits mailing list