[PATCH] D32280: TableGen: Add support of Intrinsics with multiple returns

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 14:51:17 PDT 2017


The patch never made it to the list, but for posterity it looks like so:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: numresults.patch
Type: text/x-patch
Size: 834 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170503/33e517f2/attachment.bin>
-------------- next part --------------

This looks correct, but please add a comment to the effect of "Check the
number of results before handling intrinsics, because Operator may be
updated in that path" or something. With that change, LGTM.

Matthias Braun via Phabricator <reviews at reviews.llvm.org> writes:
> MatzeB resigned from this revision.
> MatzeB edited reviewers, added: bogner, ab; removed: MatzeB.
> MatzeB added a comment.
>
> Unfortunately I am not a good reviewer for the DAGPattern part of
> TableGen. Adding some people who may know about SelectionDAG.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D32280


More information about the llvm-commits mailing list