[PATCH] D32701: [LLVM][inline-asm][Altmacor] Altmacro string delimiter '<..>'

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

You seem to have lost the negative test.



================
Comment at: lib/MC/MCParser/AsmLexer.cpp:464
 /// LexQuote: String: "..."
-AsmToken AsmLexer::LexQuote() {
+AsmToken AsmLexer::LexQuote(char Dilimiter) {
   int CurChar = getNextChar();
----------------
Delimiter


================
Comment at: test/MC/AsmParser/altmacro_string.s:28
+# CHECK:  simpleCheck1:
+# CHECK: addl    $0, %eax
+.macro concat string1 string2 string3
----------------
Shouldn't this be `$1`?


https://reviews.llvm.org/D32701