[llvm] r302010 - [X86] Refactored LowerINTRINSIC_W_CHAIN to use a switch statament. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 03:40:18 PDT 2017


Author: rksimon
Date: Wed May  3 05:40:18 2017
New Revision: 302010

URL: http://llvm.org/viewvc/llvm-project?rev=302010&view=rev
Log:
[X86] Refactored LowerINTRINSIC_W_CHAIN to use a switch statament. NFCI.

Pre-commit as requested in D32769.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=302010&r1=302009&r2=302010&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed May  3 05:40:18 2017
@@ -20284,16 +20284,17 @@ static SDValue LowerINTRINSIC_W_CHAIN(SD
                                       SelectionDAG &DAG) {
   unsigned IntNo = cast<ConstantSDNode>(Op.getOperand(1))->getZExtValue();
 
-  const IntrinsicData* IntrData = getIntrinsicWithChain(IntNo);
+  const IntrinsicData *IntrData = getIntrinsicWithChain(IntNo);
   if (!IntrData) {
-    if (IntNo == llvm::Intrinsic::x86_seh_ehregnode)
+    switch (IntNo) {
+    case llvm::Intrinsic::x86_seh_ehregnode:
       return MarkEHRegistrationNode(Op, DAG);
-    if (IntNo == llvm::Intrinsic::x86_seh_ehguard)
+    case llvm::Intrinsic::x86_seh_ehguard:
       return MarkEHGuard(Op, DAG);
-    if (IntNo == llvm::Intrinsic::x86_flags_read_u32 ||
-        IntNo == llvm::Intrinsic::x86_flags_read_u64 ||
-        IntNo == llvm::Intrinsic::x86_flags_write_u32 ||
-        IntNo == llvm::Intrinsic::x86_flags_write_u64) {
+    case llvm::Intrinsic::x86_flags_read_u32:
+    case llvm::Intrinsic::x86_flags_read_u64:
+    case llvm::Intrinsic::x86_flags_write_u32:
+    case llvm::Intrinsic::x86_flags_write_u64: {
       // We need a frame pointer because this will get lowered to a PUSH/POP
       // sequence.
       MachineFrameInfo &MFI = DAG.getMachineFunction().getFrameInfo();
@@ -20302,6 +20303,7 @@ static SDValue LowerINTRINSIC_W_CHAIN(SD
       // during ExpandISelPseudos in EmitInstrWithCustomInserter.
       return SDValue();
     }
+    }
     return SDValue();
   }
 




More information about the llvm-commits mailing list