[PATCH] D32289: [ELF] - Linkerscript: support combination of linkerscript and --compress-debug-sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 02:21:32 PDT 2017


ruiu added inline comments.


================
Comment at: test/ELF/linkerscript/compress-debug-sections.s:17
+# RUN: ld.lld -O0 %t1.o %t2.o %t2.script -o %t2 --compress-debug-sections=zlib
+# RUN: llvm-dwarfdump %t2 | FileCheck %s
+
----------------
I don't think you are actually testing the new code. Please use llvm-objdump or llvm-readelf to verify that debug sections don't SHT_COMPRESSED if linker scripts are in use. You don't need to use llvm-dwarfdump as the contents doesn't matter.


https://reviews.llvm.org/D32289





More information about the llvm-commits mailing list