[PATCH] D32289: [ELF] - Linkerscript: support combination of linkerscript and --compress-debug-sections.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/linkerscript/compress-debug-sections.s:15
+
+# CHECK:       .debug_str contents:
+# CHECK-NEXT:    CCC
----------------
ruiu wrote:
> I don't think you really need this much hand-crafted debug info. You can just create an object file with `-g`, link it with LLD and verify that the debug section doesn't have SHF_COMPRESSED flag by using llvm-objdump or readobj.
> 
But that will not cover things this patch implements.
I believe we still want to check that compressing - decompressing flow producing the same results in scripted case. When you asked in previous diff to reduce amount of repitions of A, B, C, D, that revealed an issue in calculating output section size, what produced broken zlib stream, I think it is worth to check that this case works now. Just checking the flag would not reveal it.

I think it is probably not important to check how mergeable synthetic compressed section works. I believe I can significantly simplify the testcase to use .debug_str only with merging disabled. Let me try.


https://reviews.llvm.org/D32289