[PATCH] D32706: [AArch64] Consider widening instructions in cast cost calculation

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

In https://reviews.llvm.org/D32706#743682, @mssimpso wrote:

> Addressed Kristof's comments.
>
> - Changed wording to refer to "widening" instructions rather than "lengthening" instructions.
> - Changed function name to is isWideningFree.
> - Updated the logic to consider the W instruction variants in addition to the L variants.
> - Added code generation tests along side the cost test cases.
> - Added additional tests for the W variants.


Thanks Matt.
I'm not familiar enough with this code to feel comfortable approving, so I think someone else should do that.
Other than that, I only have one more remark, now that I've looked at the patch again: maybe there should also be a "negative" test, i.e. verifying that a non-zero cost is computed when a widening instruction cannot be generated, e.g. when the type operated on cannot map to a native instruction?


https://reviews.llvm.org/D32706