[PATCH] D32773: Update VP prof metadata during inlining.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 17:54:24 PDT 2017


eraman added inline comments.


================
Comment at: lib/IR/Instruction.cpp:637
+  for (unsigned i = 1; i < ProfileData->getNumOperands(); i++)
+    if ((i % 2) == 1 && ProfDataName->getString().equals("VP")) {
+      Vals.push_back(ProfileData->getOperand(i));
----------------
This is not easy to read. Why are only odd indices pushed into Vals? I suppose you want to scale only operand 2. I suggest you separate the two cases (VP aand branch_weights) and handle them separately.


https://reviews.llvm.org/D32773





More information about the llvm-commits mailing list